Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display inline search result attributes #7855

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented Feb 27, 2024

Summary

Show the matched attributes in a single line underneath each row to use the space more efficiently.

https://www.loom.com/share/922a8d28067f4f1ab774dd67db5000aa?sid=e8b38230-9420-4b5a-a211-816d3a866b79

How did you test this change?

  1. View the logs table
  2. Search by an attribute
  • Attribute is displayed underneath each row
  • No ; is rendered
  1. Add another search attribute
  • Attribute is added underneath in the same row
  • Separated by a ;
  1. Add another attribute
  • Attribute is added underneath in the same row (breaks to new row if needed)
  • Separated by a ;

Are there any deployment considerations?

N/A

Does this work require review from our design team?

Yes - https://www.figma.com/file/rdBPNzn7Klk6RG1LHUCE5B/Screen-Designs?node-id=15015%3A163252&mode=dev

Copy link

changeset-bot bot commented Feb 27, 2024

⚠️ No Changeset found

Latest commit: 4cd4c73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets changed the title Display inlign search results Display inline search result attributes Feb 27, 2024
@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review February 27, 2024 17:40
@SpennyNDaJets SpennyNDaJets requested review from a team and ccschmitz and removed request for a team February 27, 2024 17:40
Copy link
Contributor

@ccschmitz ccschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + click test LGTM 😻

One minor regression I noticed is that the empty text in cells without values isn't centered anymore. Might be something worth cleaning up quick before merging.

@SpennyNDaJets
Copy link
Contributor Author

SpennyNDaJets commented Feb 28, 2024

Code + click test LGTM 😻

One minor regression I noticed is that the empty text in cells without values isn't centered anymore. Might be something worth cleaning up quick before merging.

Not sure if this was pre-existing, but I have a PR to fix the session and align the session columns here which I will wait to merge - #7854

Edit: Actually just going to merge that PR into this one

@SpennyNDaJets SpennyNDaJets mentioned this pull request Feb 28, 2024
6 tasks
@SpennyNDaJets SpennyNDaJets merged commit b5a519b into main Feb 28, 2024
11 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/display-inline-search-results branch February 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants