-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display inline search result attributes #7855
Conversation
|
This reverts commit 955d742.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code + click test LGTM 😻
One minor regression I noticed is that the empty
text in cells without values isn't centered anymore. Might be something worth cleaning up quick before merging.
Not sure if this was pre-existing, but I have a PR to fix the session and align the session columns here which I will wait to merge - #7854 Edit: Actually just going to merge that PR into this one |
Summary
Show the matched attributes in a single line underneath each row to use the space more efficiently.
https://www.loom.com/share/922a8d28067f4f1ab774dd67db5000aa?sid=e8b38230-9420-4b5a-a211-816d3a866b79
How did you test this change?
;
is rendered;
;
Are there any deployment considerations?
N/A
Does this work require review from our design team?
Yes - https://www.figma.com/file/rdBPNzn7Klk6RG1LHUCE5B/Screen-Designs?node-id=15015%3A163252&mode=dev