Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync key and values across searches #7889

Merged
merged 8 commits into from
Mar 6, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented Mar 1, 2024

Summary

The sessions and errors searches use entirely different methods of fetching keys and values than the logs and traces. We need to sync these in order to migrate errors and sessions into the new search method.

Simplify the frontend to use two generic query for keys and values, respectively, passing in the type to query over.

How did you test this change?

  1. View the logs page
  • Can still query keys
  • Can still query values
  1. View the traces page
  • Can still query keys
  • Can still query values

No changes to the sessions and errors product, but confirm that Grafana and Filter ingestions are not affected

  • No regressions to Grafana
  • No regressions to filter ingestions

Are there any deployment considerations?

N/A

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented Mar 1, 2024

⚠️ No Changeset found

Latest commit: c931d74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets changed the title Spenny/sync key and values across searches Sync key and values across searches Mar 4, 2024
@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review March 4, 2024 18:01
@SpennyNDaJets SpennyNDaJets requested review from a team, Vadman97 and mayberryzane and removed request for a team March 4, 2024 18:01
@SpennyNDaJets
Copy link
Contributor Author

@mayberryzane wanted to make sure the changes to the error tables and keys would not have a regression on Grafana? Seems like these keys were not being used since there were no columns they would map to?

@SpennyNDaJets SpennyNDaJets merged commit 1fee43b into main Mar 6, 2024
13 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/sync-key-and-values-across-searches branch March 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants