-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync key and values across searches #7889
Sync key and values across searches #7889
Conversation
|
@mayberryzane wanted to make sure the changes to the error tables and keys would not have a regression on Grafana? Seems like these keys were not being used since there were no columns they would map to? |
Summary
The sessions and errors searches use entirely different methods of fetching keys and values than the logs and traces. We need to sync these in order to migrate errors and sessions into the new search method.
Simplify the frontend to use two generic query for keys and values, respectively, passing in the type to query over.
How did you test this change?
No changes to the sessions and errors product, but confirm that Grafana and Filter ingestions are not affected
Are there any deployment considerations?
N/A
Does this work require review from our design team?
N/A