Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try gorm upgrades again #7967

Merged
merged 3 commits into from
Mar 11, 2024
Merged

try gorm upgrades again #7967

merged 3 commits into from
Mar 11, 2024

Conversation

mayberryzane
Copy link
Contributor

Summary

  • first go dependency upgrade upgrade go dependencies #7937 was hanging during db migration because gorm was attempting to convert some integer columns to bigint. now that those are overridden by an integer struct tag, planning to merge in these dependency upgrades again

How did you test this change?

  • tested locally by auto-migrating from previous version and in a fresh install to make sure both worked

Are there any deployment considerations?

  • no

Does this work require review from our design team?

  • no

Copy link

changeset-bot bot commented Mar 9, 2024

⚠️ No Changeset found

Latest commit: ac684fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Are there any deployment considerations?

Do we need a rollout/rollback strategy incase anything goes wrong?

@mayberryzane
Copy link
Contributor Author

LGTM!

Are there any deployment considerations?

Do we need a rollout/rollback strategy incase anything goes wrong?

GORM automigrate won't do anything that would cause data loss, the biggest risk is an accidental DDL change that affects performance. Will be monitoring the rollout - if there are issues, we will revert ASAP to automigrate back to the original state. If there are issues after that, we have daily snapshots and can manually look at the delta to apply schema changes to the prod DB. Finally, if that causes issues, we can restore the entire DB from a snapshot and rewind the Kafka queues. This would be the worst case scenario as it would cause a few hour interruption where customers wouldn't see recent data, but would not cause data loss.

@mayberryzane mayberryzane merged commit a9a7dfb into main Mar 11, 2024
13 checks passed
@mayberryzane mayberryzane deleted the zane/go_upgrades_v2 branch March 11, 2024 18:54
mayberryzane added a commit that referenced this pull request Mar 11, 2024
mayberryzane added a commit that referenced this pull request Mar 11, 2024
## Summary
- reverts #7975 and #7967 - was in the process of fixing some default
columns being migrated on every build, and ran into another issue
"LastInsertId is not supported by this driver" - still digging into the
root cause
<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

## How did you test this change?
- is `git revert`ing two commits
<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?
- no, may automigrate some columns back to their original definition,
not too concerning
<!--
 Backend - Do we need to consider migrations or backfilling data?
-->

## Does this work require review from our design team?
- no
<!--
 Request review from julian-highlight / our design team 
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants