-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try gorm upgrades again #7967
try gorm upgrades again #7967
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Are there any deployment considerations?
Do we need a rollout/rollback strategy incase anything goes wrong?
GORM automigrate won't do anything that would cause data loss, the biggest risk is an accidental DDL change that affects performance. Will be monitoring the rollout - if there are issues, we will revert ASAP to automigrate back to the original state. If there are issues after that, we have daily snapshots and can manually look at the delta to apply schema changes to the prod DB. Finally, if that causes issues, we can restore the entire DB from a snapshot and rewind the Kafka queues. This would be the worst case scenario as it would cause a few hour interruption where customers wouldn't see recent data, but would not cause data loss. |
…ne/go_upgrades_v2
This reverts commit a9a7dfb.
## Summary - reverts #7975 and #7967 - was in the process of fixing some default columns being migrated on every build, and ran into another issue "LastInsertId is not supported by this driver" - still digging into the root cause <!-- Ideally, there is an attached GitHub issue that will describe the "why". If relevant, use this section to call out any additional information you'd like to _highlight_ to the reviewer. --> ## How did you test this change? - is `git revert`ing two commits <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> ## Are there any deployment considerations? - no, may automigrate some columns back to their original definition, not too concerning <!-- Backend - Do we need to consider migrations or backfilling data? --> ## Does this work require review from our design team? - no <!-- Request review from julian-highlight / our design team -->
Summary
How did you test this change?
Are there any deployment considerations?
Does this work require review from our design team?