-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gorm type for JSONB fields #7975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayberryzane
requested review from
a team and
Vadman97
and removed request for
a team
March 11, 2024 19:24
|
Vadman97
approved these changes
Mar 11, 2024
mayberryzane
added a commit
that referenced
this pull request
Mar 11, 2024
This reverts commit 47d1eeb.
mayberryzane
added a commit
that referenced
this pull request
Mar 11, 2024
## Summary - reverts #7975 and #7967 - was in the process of fixing some default columns being migrated on every build, and ran into another issue "LastInsertId is not supported by this driver" - still digging into the root cause <!-- Ideally, there is an attached GitHub issue that will describe the "why". If relevant, use this section to call out any additional information you'd like to _highlight_ to the reviewer. --> ## How did you test this change? - is `git revert`ing two commits <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> ## Are there any deployment considerations? - no, may automigrate some columns back to their original definition, not too concerning <!-- Backend - Do we need to consider migrations or backfilling data? --> ## Does this work require review from our design team? - no <!-- Request review from julian-highlight / our design team -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
type:text
, explicitly tag to make sure automigrate doesn't happenRetryable
from automigrated models as it is unused, it also hastype:text
on this fieldHow did you test this change?
make start
locally to automigrate, made sure all of these columns hadjsonb
typeAre there any deployment considerations?
Does this work require review from our design team?