Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gorm type for JSONB fields #7975

Merged
merged 2 commits into from
Mar 11, 2024
Merged

add gorm type for JSONB fields #7975

merged 2 commits into from
Mar 11, 2024

Conversation

mayberryzane
Copy link
Contributor

Summary

  • newer version of GORM wants to migrate these fields to type:text, explicitly tag to make sure automigrate doesn't happen
  • remove Retryable from automigrated models as it is unused, it also has type:text on this field

How did you test this change?

  • ran make start locally to automigrate, made sure all of these columns had jsonb type

Are there any deployment considerations?

  • want to deploy this to fix automigrate in previous GORM PR, can revert this and previous commit if issues

Does this work require review from our design team?

  • no

@mayberryzane mayberryzane requested review from a team and Vadman97 and removed request for a team March 11, 2024 19:24
Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: 48bbcc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@mayberryzane mayberryzane enabled auto-merge (squash) March 11, 2024 20:17
@mayberryzane mayberryzane merged commit 47d1eeb into main Mar 11, 2024
12 of 13 checks passed
@mayberryzane mayberryzane deleted the zane/fix_jsonb_migration branch March 11, 2024 20:27
mayberryzane added a commit that referenced this pull request Mar 11, 2024
mayberryzane added a commit that referenced this pull request Mar 11, 2024
## Summary
- reverts #7975 and #7967 - was in the process of fixing some default
columns being migrated on every build, and ran into another issue
"LastInsertId is not supported by this driver" - still digging into the
root cause
<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

## How did you test this change?
- is `git revert`ing two commits
<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?
- no, may automigrate some columns back to their original definition,
not too concerning
<!--
 Backend - Do we need to consider migrations or backfilling data?
-->

## Does this work require review from our design team?
- no
<!--
 Request review from julian-highlight / our design team 
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants