-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional error fields to query #8210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
7 tasks
mayberryzane
approved these changes
Apr 9, 2024
SpennyNDaJets
added a commit
that referenced
this pull request
Apr 16, 2024
## Summary Swap out the error query builder for the new search form. Other notable changes/non-changes: - removes the error search context wrapper - moves the error saved searches to the new table - removes errors from Command bar - removes preloading errors - does not edit the ingestion filters https://www.loom.com/share/88e55cbd117d41688a10fccceaed12d6?sid=3a3cbb17-bf4b-4b5b-8e27-80629719a75b ## How did you test this change? Note: searching by `trace_id` or `secure_session_id` on preview is broken until #8210 is merged in 1. Search sessions - [ ] Session search still works - [ ] Can save a saved search - [ ] Can delete a saved search 2) Search errors - [ ] Can search for errors (by group and object keys) - [ ] Can save a saved search - [ ] Ca delete a saved search 3) Edit error ingestion filters - [ ] Can still add error ingestion filters with old query logic ## Are there any deployment considerations? Must migrate saved searches before deploying ## Does this work require review from our design team? Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support search errors by trace id and secure session id, when using the error_joined_vw.
How did you test this change?
Are there any deployment considerations?
N/A
Does this work require review from our design team?
N/A