Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional error fields to query #8210

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

Summary

Support search errors by trace id and secure session id, when using the error_joined_vw.

How did you test this change?

  1. Run migrations.
  2. Confirm in clickhouse that the rows are on the table

Are there any deployment considerations?

N/A

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented Apr 9, 2024

⚠️ No Changeset found

Latest commit: 4984af8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets requested review from a team, Vadman97 and mayberryzane and removed request for a team April 9, 2024 17:30
@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review April 9, 2024 17:30
@SpennyNDaJets SpennyNDaJets mentioned this pull request Apr 9, 2024
7 tasks
@SpennyNDaJets SpennyNDaJets merged commit 59c3d71 into main Apr 10, 2024
13 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/support-additional-error-fields branch April 10, 2024 14:02
SpennyNDaJets added a commit that referenced this pull request Apr 16, 2024
## Summary
Swap out the error query builder for the new search form.

Other notable changes/non-changes:
- removes the error search context wrapper
- moves the error saved searches to the new table
- removes errors from Command bar
- removes preloading errors
- does not edit the ingestion filters


https://www.loom.com/share/88e55cbd117d41688a10fccceaed12d6?sid=3a3cbb17-bf4b-4b5b-8e27-80629719a75b

## How did you test this change?
Note: searching by `trace_id` or `secure_session_id` on preview is
broken until #8210 is merged
in

1. Search sessions
- [ ] Session search still works
- [ ] Can save a saved search
- [ ] Can delete a saved search
2) Search errors
- [ ] Can search for errors (by group and object keys)
- [ ] Can save a saved search
- [ ] Ca delete a saved search
3) Edit error ingestion filters
- [ ] Can still add error ingestion filters with old query logic

## Are there any deployment considerations?
Must migrate saved searches before deploying

## Does this work require review from our design team?
Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants