-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search params being set in wrong place #8214
Fix search params being set in wrong place #8214
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…earch-form-on-related-logs-panel-broken
@SpennyNDaJets thanks for catching that! In that context I think we want to disable that feature entirely since we don't want people interacting with that search box. I just fixed that up and merged in your latest changes + handled conflicts. Should be ready for another look whenever you have time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click test looks good to me!
Summary
We have a bug where interacting with UI in the related resource panel will manipulate the main page's search query rather than the query used for the related resource in the panel. e.g. if you are on the traces page and click on "Apply as filter" on a log attribute from the logs' related resource panel it will apply the filter on the traces' query.
My workaround for this is to move some of the search state/logic into a
SearchContext
that can be added around search components, then use the context (viauseSearchContext
) to access a setter that will update thequery
just for that instance of the search.Also makes a few small tweaks to fix some issues I noticed while click testing.
How did you test this change?
Are there any deployment considerations?
Should only fix a client-side bug. No backend changes.
Does this work require review from our design team?
N/A