Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve python SDK #8259

Merged
merged 9 commits into from
Apr 16, 2024
Merged

improve python SDK #8259

merged 9 commits into from
Apr 16, 2024

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Apr 15, 2024

Summary

  • increase batching to help avoid dropping traces and logs
  • add debug setting to turn on opentelemetry debug logging
  • support custom log handler usage in python
  • improve span names for web frameworks (django, fastapi, flask)

Closes HIG-4498

How did you test this change?

Screenshot from 2024-04-15 16-33-33
Screenshot from 2024-04-15 16-45-38
Screenshot from 2024-04-15 16-52-14

Screenshot from 2024-04-15 20-48-17
Screenshot from 2024-04-15 20-48-22
Screenshot from 2024-04-15 20-49-13

Are there any deployment considerations?

new python sdk version

Does this work require review from our design team?

no

@Vadman97 Vadman97 requested review from a team and SpennyNDaJets and removed request for a team April 15, 2024 23:16
Copy link

linear bot commented Apr 15, 2024

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: 7f65420

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
482 413 86% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
sdk/highlight-py/highlight_io/integrations/django.py 60% 🟢
sdk/highlight-py/highlight_io/integrations/fastapi.py 100% 🟢
sdk/highlight-py/highlight_io/integrations/flask.py 66% 🟢
sdk/highlight-py/highlight_io/sdk.py 90% 🟢
TOTAL 79% 🟢

updated for commit: 7f65420 by action🐍

Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vadman97 Vadman97 disabled auto-merge April 16, 2024 15:39
@Vadman97 Vadman97 enabled auto-merge (squash) April 16, 2024 15:41
@Vadman97 Vadman97 merged commit 9a42914 into main Apr 16, 2024
15 checks passed
@Vadman97 Vadman97 deleted the vadim/py-sdk-batching branch April 16, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants