Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nestjs sdk requiring endpoint to return #8276

Merged

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Apr 16, 2024

Summary

  • Updates node.js SDK export batch settings to help with dropped spans
  • Fixes nestjs sdk crashing on endpoints where there was no returned data
  • Improves nestjs spans and context propagation for parent->child spans
  • Renames nodejs internal spans to make it easier to filter them out.

8844ac6 should fix HIG-4518

How did you test this change?

Screenshot from 2024-04-16 22-20-14

Screenshot from 2024-04-17 11-27-06

Screenshot from 2024-04-17 11-34-10

Are there any deployment considerations?

changeset

Does this work require review from our design team?

no

@Vadman97 Vadman97 requested review from a team and ccschmitz and removed request for a team April 16, 2024 23:55
Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 8844ac6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

@ccschmitz ccschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code changes look good. Let me know if there's anything you'd like me to click test before merging!

@Vadman97 Vadman97 enabled auto-merge (squash) April 17, 2024 17:13
Copy link

linear bot commented Apr 17, 2024

@Vadman97 Vadman97 merged commit ec466b8 into main Apr 17, 2024
13 checks passed
@Vadman97 Vadman97 deleted the hig-4497-highlight-runnest-v350-typeerror-you-provided-an-invalid branch April 17, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants