Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report cors network request failures #8333

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Apr 23, 2024

Summary

Customers have asked to capture CORS and other failed network requests in the session
network devtools tab. Ensure that we do not miss fetch errors by reporting additional metadata.

Closes WHO-2

How did you test this change?

image

Are there any deployment considerations?

changeset

Does this work require review from our design team?

no

Copy link

linear bot commented Apr 23, 2024

Copy link

changeset-bot bot commented Apr 23, 2024

⚠️ No Changeset found

Latest commit: 34a97e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

sdk/client/src/index.tsx Outdated Show resolved Hide resolved
@Vadman97 Vadman97 requested review from a team and SpennyNDaJets and removed request for a team April 24, 2024 23:53
@Vadman97 Vadman97 marked this pull request as ready for review April 24, 2024 23:53
frontend/package.json Outdated Show resolved Hide resolved
@Vadman97 Vadman97 enabled auto-merge (squash) April 30, 2024 21:34
@Vadman97 Vadman97 force-pushed the hig-4539-report-cors-errors-via-the-browser-sdk branch from e12069c to 34a97e3 Compare April 30, 2024 21:34
@Vadman97 Vadman97 merged commit 6b4f2fa into main Apr 30, 2024
21 checks passed
@Vadman97 Vadman97 deleted the hig-4539-report-cors-errors-via-the-browser-sdk branch April 30, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants