-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report cors network request failures #8333
Merged
Vadman97
merged 1 commit into
main
from
hig-4539-report-cors-errors-via-the-browser-sdk
Apr 30, 2024
Merged
report cors network request failures #8333
Vadman97
merged 1 commit into
main
from
hig-4539-report-cors-errors-via-the-browser-sdk
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vadman97
force-pushed
the
hig-4539-report-cors-errors-via-the-browser-sdk
branch
from
April 24, 2024 23:22
ec03a05
to
cb05e53
Compare
Vadman97
commented
Apr 24, 2024
Vadman97
requested review from
a team and
SpennyNDaJets
and removed request for
a team
April 24, 2024 23:53
Vadman97
commented
Apr 24, 2024
SpennyNDaJets
approved these changes
Apr 29, 2024
Vadman97
force-pushed
the
hig-4539-report-cors-errors-via-the-browser-sdk
branch
from
April 30, 2024 21:34
e12069c
to
34a97e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Customers have asked to capture CORS and other failed network requests in the session
network devtools tab. Ensure that we do not miss fetch errors by reporting additional metadata.
Closes WHO-2
How did you test this change?
Are there any deployment considerations?
changeset
Does this work require review from our design team?
no