Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error alert search queries #8409

Merged
merged 7 commits into from
May 2, 2024
Merged

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented May 1, 2024

Summary

Allow users to specify queries on the error alerts

  • Removes (and migrates) the excluded environments
  • Removes regex expressions for new alerts and alerts with no regex expressions

https://www.loom.com/share/244777ebf646411bbca64be9f3ea3091?sid=0ba759d4-0d15-4ee8-840c-a540842b4510

How did you test this change?

  1. Create a new error alert with a query
    a) Add a threshold of 1
    b) Add a slack/discord channel or email
  2. Kick an error off that matches the query
  • Alert notifies correct channel
  1. Kick an error off that does NOT match the query
  • Alert does not notify the channel

Are there any deployment considerations?

Run migration first

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: 9ca9287

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets changed the title Spenny/error alert search queries Error alert search queries May 1, 2024
defer highlight.Stop()
hlog.Init()

ctx := context.TODO()

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review May 2, 2024 18:21
@SpennyNDaJets SpennyNDaJets requested review from a team and mayberryzane and removed request for a team May 2, 2024 18:21
Copy link
Contributor

@mayberryzane mayberryzane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for video and explanation on not migrating the regex field, makes sense to me! on that same topic - is it possible to filter on the stack trace right now? if not, it could be something useful to have, or in the future add some fake key that we can use to filter on both event and stack trace at the same time to replace this

@SpennyNDaJets
Copy link
Contributor Author

thanks for video and explanation on not migrating the regex field, makes sense to me! on that same topic - is it possible to filter on the stack trace right now? if not, it could be something useful to have, or in the future add some fake key that we can use to filter on both event and stack trace at the same time to replace this

At the moment, it is not possible - we are storing the stack trace in clickhouse, so would have to add there or come up with something more creative. I created a card here: https://linear.app/highlight/issue/HIG-4609/allow-filtering-by-stack-trace-matching

@SpennyNDaJets SpennyNDaJets merged commit 9cf0401 into main May 2, 2024
21 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/error-alert-search-queries branch May 2, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants