-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draw dots at line chart discontinuities #8450
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Summary
- Feature Addition: Implements drawing dots at discontinuities in line charts to indicate missing data points. This enhances clarity in data visualization by marking invisible points on graphs where data is absent.
- Implementation Details: A
CustomizedDot
component is introduced within theArea
component of the line chart. The logic identifies null values adjacent to non-null values and renders a dot at the non-null point, signaling a discontinuity.
Potential Pitfalls and Notes
- Design Consideration: The current implementation uses 2px filled circles for dots. Awaiting feedback from the design team for potential style adjustments.
- Testing: The feature has been click-tested locally, but further testing, especially automated tests, could ensure robustness.
- Deployment: No specific deployment considerations mentioned, indicating a straightforward integration into the main branch.
Opportunities
- Code Reuse: If similar patterns of data discontinuity visualization are needed elsewhere, the
CustomizedDot
component logic could be abstracted for reuse. - Future Enhancements: Depending on user feedback, additional customization options for the dots (size, color, shape) could be introduced to better align with various design requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not click test, but LGTM!
Summary
How did you test this change?
Are there any deployment considerations?
Does this work require review from our design team?