Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query builder #8476

Merged
merged 4 commits into from
May 7, 2024
Merged

Remove query builder #8476

merged 4 commits into from
May 7, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented May 6, 2024

Summary

Swap out the query builder in the project filters, and clean up any dead code associated with the query builder

https://www.loom.com/share/c9921c6005a345dba1519c2710274f59

How did you test this change?

  1. On main, update workspace to be in the "enterprise" tier: UPDATE workspaces SET plan_tier = 'Enterprise' WHERE id = 1;
  2. Click into project settings and add project filters for errors and sessions
  3. Check the query in Postgres
  4. Switch to this branch
  5. Load the project filters created with the old query builder
  • Able to load filters
  • Able to edit filters
  • Format matched in postgres

Are there any deployment considerations?

N/A

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented May 6, 2024

⚠️ No Changeset found

Latest commit: 692557b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets changed the title Spenny/remove query builder Remove query builder May 6, 2024
@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review May 6, 2024 20:12
@SpennyNDaJets SpennyNDaJets changed the base branch from main to spenny/remove-error-segments May 6, 2024 20:12
@SpennyNDaJets SpennyNDaJets requested review from a team, ccschmitz and Vadman97 and removed request for a team May 6, 2024 20:13
Base automatically changed from spenny/remove-error-segments to main May 6, 2024 21:35
Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🚢

@SpennyNDaJets SpennyNDaJets merged commit 3f25da5 into main May 7, 2024
21 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/remove-query-builder branch May 7, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants