Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make session variables more understandable #8526

Merged
merged 2 commits into from
May 10, 2024

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented May 10, 2024

Summary

Update the following variables names

  • processed -> completed (no additional effects)
  • viewed -> viewed_by_anyone (no additional effects)
  • loc_state -> state
    • key/value suggestions for state will only include those states added as properties after the deployment
    • key/value suggestions for loc_state will still be visible after deployment but only for states before deployment
      • will stop be suggested over time as it stops it being written to clickhouse

The old keys are still supported in search but will not be added as a suggestion, unless otherwise noted. All saved segments and filters will still work properly with no migrations necessary

https://www.loom.com/share/87ee4b30f8464114a1ef487934b1e7dd?sid=beb26451-febd-4b24-942a-7ac6799981c0

How did you test this change?

  1. Load the session page
  • completed=true is the default search
  • Only completed sessions displayed
  1. Change to completed=false
  • keys and values suggested
  • Only non-completed sessions displayed
  1. Change to processed=false
  • keys and values NOT suggested
  • Only non-completed sessions displayed
  1. Added viewed_by_anyone=true
  • keys and values suggested
  • Only viewed sessions displayed
  1. Change to viewed=false
  • keys and values NOT suggested
  • Only non-viewed sessions displayed
  1. Add state=[some value]
  • keys and values suggested
  • Only sessions from that state displayed
  1. Change to loc_state=[some value]
  • keys and values suggested
  • Only sessions from that state displayed

Are there any deployment considerations?

N/A

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 2ec0c0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review May 10, 2024 15:05
@SpennyNDaJets SpennyNDaJets requested review from a team and ccschmitz and removed request for a team May 10, 2024 15:05
Copy link
Contributor

@ccschmitz ccschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpennyNDaJets SpennyNDaJets enabled auto-merge (squash) May 10, 2024 16:08
@SpennyNDaJets SpennyNDaJets merged commit 5392aed into main May 10, 2024
21 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/rename-session-variables branch May 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants