Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record network request bodies and headers in trace #8551

Merged

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented May 13, 2024

Summary

  • records additional attributes (http request / response headers and body) as part of frontend traces
  • records more attributes in the browser performance capture to record detailed request timing
  • updates opentelemetry go sdks to latest versions and uses latest opentelemetry semantic convention

How did you test this change?

Screenshot from 2024-05-14 10-36-30

Screenshot from 2024-05-13 15-40-29

Screenshot from 2024-05-13 14-56-03

Are there any deployment considerations?

no

Does this work require review from our design team?

no

@Vadman97 Vadman97 requested review from a team and mayberryzane and removed request for a team May 13, 2024 21:57
Copy link

linear bot commented May 13, 2024

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 9b015e1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 changed the title Sup 8 record network request bodies and headers in trace record network request bodies and headers in trace May 13, 2024
@Vadman97 Vadman97 enabled auto-merge (squash) May 15, 2024 22:44
@Vadman97 Vadman97 force-pushed the sup-8-record-network-request-bodies-and-headers-in-trace branch from 3fa78a3 to 9b015e1 Compare May 15, 2024 22:44
@Vadman97 Vadman97 merged commit 2a90db8 into main May 15, 2024
25 checks passed
@Vadman97 Vadman97 deleted the sup-8-record-network-request-bodies-and-headers-in-trace branch May 15, 2024 23:37
import('@highlight-run/client').then(async ({ Highlight }) => {
highlight_obj = new Highlight(
client_options,
first_load_listeners,
)
initializeFetchListener()
initializeWebSocketListener()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vadman97 I'm looking at setting up the OTEL provider around here and was curious, why did you have to add this initialization logic multiple times here in addition to at the bottom of this file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants