✨ - add cli tool to quickly check relevance conflicts #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonder if it we should combine superpowers: #1525 |
|
@ellismarkf This is pretty great. Thanks! Sorry it sat around for so long. |
joshgoebel
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having to individually check for relevance score conflicts with the
developer.htmlUI, this PR introduces a Node program to check for relevance score conflicts programmatically, all at once, displaying results in the terminal.To run the check:
node test/detect/checkAutoDetectResults.jsIf there are no conflicts:
The tool distinguishes between moderate and severe conflicts, where moderate conflicts are when the expected language is returned as the
second_bestresult, and severe conflicts are when the expected language was out-scored by both the primary andsecond_bestresults.Moderate conflicts:
Severe conflicts:
The goal of this tool is to make it easier to understand relevance, as well as give faster feedback to developers about where their language is over-relevant.
The tool should be invoked after building the project, and works best when doing a full, uncompressed build, ie
node tools/build.js -n. In compressed mode,relevancedoesn't seem to be returned, or at least not in the same way, so I coded around that.(To capture above screenshots, I arbitrarily spiked relevance in Typescript, Javascript, and Clojure, then discarded the changes. Don't worry 😉 )