Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C23 keywords and types #3836

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

Eisenwave
Copy link
Contributor

Changes

This PR adds a few keywords that have been introduces in C23. Firstly, C now also has constexpr and the preprocessor got #elifdef and #elifndef. See https://en.cppreference.com/w/c/23.

Secondly, there are numerous extended floating point types (not yet documented on cppreference). See N3096 H.5.1 Keywords.

Checklist

  • Added markup tests, or they don't apply here because this is a simple expansion of the keyword list
  • Updated the changelog at CHANGES.md

Copy link

@TOMWT-qwq TOMWT-qwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGES.md is out of date.

CHANGES.md Outdated
@@ -34,6 +34,7 @@ Core Grammars:
- fix(haskell) do not treat double dashes inside infix operators as comments [Zlondrej][]
- enh(rust) added `eprintln!` macro [qoheniac][]
- enh(leaf) update syntax to 4.0 [Samuel Bishop][]
- enh(c) added more C23 keywords and preprcoessor directives [Eisenwave][]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the link on lines 44-53.

Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for changelog link!

@joshgoebel
Copy link
Member

You can merge or rebase on latest to get newest changelog.

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +111 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +3 B
es/highlight.min.js 8.2 KB 8.2 KB +3 B
es/languages/c.min.js 1.86 KB 1.91 KB +50 B
highlight.min.js 8.23 KB 8.23 KB +3 B
languages/c.min.js 1.87 KB 1.92 KB +52 B

@joshgoebel joshgoebel merged commit e75b7e4 into highlightjs:main Mar 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants