-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: startColumn makes CSV parser return empty array. #7272
Comments
Related: #7265 |
There's still something fishy - check out this test. It concatenates column 0 with column 1. This test can replace the last test in QUnit.test('startRow, endRow, startColumn, endColumn', function (assert) {
var data =
'Pad,Pad,Pad,Pad\n' +
'Pad,Apples,Pears,Pad\n' +
'Pad,1,2,Pad\n' +
'Pad,5,6,Pad\n' +
'Pad,Pad,Pad,Pad';
Highcharts.data({
csv: data,
startRow: 1,
endRow: 3,
startColumn: 1,
endColumn: 2,
parsed: function () {
assert.strictEqual(
this.columns.length,
2,
'Two columns included'
);
assert.strictEqual(
this.columns[0].join(','),
'Apples,1,5',
'First column ok'
);
assert.strictEqual(
this.columns[0].length,
3,
'Three rows included'
);
}
});
}); |
This may be related to the fix I did for the delimiter guessing, if so I have a hunch on how to fix it. WIll try to take a look today. |
Shouldn't we keep the last test in |
Live demo with steps to reproduce
http://jsfiddle.net/hr6j17eq/2/
The text was updated successfully, but these errors were encountered: