Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support for IPv6 #43

Closed
hugoh opened this issue Jan 15, 2022 · 8 comments
Closed

Feature request: support for IPv6 #43

hugoh opened this issue Jan 15, 2022 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hugoh
Copy link
Contributor

hugoh commented Jan 15, 2022

IPv4 addresses are supported at ping hosts (e.g., 8.8.8.8), but IPv6 (e.g., 2001:4860:4860::8888) isn't on Linux as it requires the use of ping6 instead of ping.

It would be nice to support both.

@highvolt-dev
Copy link
Owner

highvolt-dev commented Jan 15, 2022

Thanks for the request, @hugoh

Should be able to implement by passing the the -6 flag to the underlying ping command for Windows and Linux but we'll need ping6 for OS X.

@highvolt-dev highvolt-dev added enhancement New feature or request good first issue Good for newcomers labels Jan 16, 2022
highvolt-dev added a commit that referenced this issue Feb 6, 2022
@highvolt-dev
Copy link
Owner

@hugoh this was implemented by #61

@hugoh
Copy link
Contributor Author

hugoh commented Feb 6, 2022 via email

@highvolt-dev
Copy link
Owner

Reopened based on feedback from @hugoh in #61

highvolt-dev added a commit that referenced this issue Feb 7, 2022
use ping6 binary if available for ipv6 ping functionality, fixes #43
@hugoh
Copy link
Contributor Author

hugoh commented Feb 9, 2022

Thanks. It's working except for 1 aspect: I could not figure out how to enable it via .env. I tried to set tmo_6, tmo_ping6, tmo_ping_6, tmo_ping-6 to True without success. Am I missing something?

@highvolt-dev
Copy link
Owner

It's intended to be set via tmo_ping_6=True

Can you verify the rest of your .env file is being parsed?

After restructuring the repo into modules and to use setup.py, it looks like the .env doesn't get picked up because it installs a copy of the program rather than using your cloned repo.

Try reinstalling with pip3 install -e . so it installs with a symlink to the repo directory or installing into a virtualenv that is a subdirectory of the repo directory so it can traverse up to get to the .env file

@hugoh
Copy link
Contributor Author

hugoh commented Feb 9, 2022

It doesn't pick up the tmo_ping_6 option.

The following .env:

tmo_ping_host=github.com
tmo_ping_6=True
tmo_skip_reboot=True
tmo_print_config=True

gives the following config:

Script configuration:
[..]
  Ping configuration:
    Host: github.com
    Count: 1
    Interval: 10
    Protocol: IPv4

It picks up tmo_ping_host but not tmo_ping_6.

@highvolt-dev
Copy link
Owner

Thanks for the sanity check, @hugoh - just committed what should be the necessary fix

hugoh added a commit to hugoh/tmo-monitor that referenced this issue May 26, 2023
* Fixed tmo_monitor.gateway module installation

* Update README.md

add Windows directions

* use meaningful exit status codes, fixes highvolt-dev#52

* clarify that a clean run will exit with status code 0 as expected

* add project logo

* First commit to log to syslog - not working yet

Moved all the logging from print_and_log to logging, but syslog doesn't
work. Need to debug.

* Made Linux syslog logging work

* Moved away from f-Strings to lower Python version requirement

* Added support for Windows (untested)

* Fixed log message format

* Fixed out-of-scope use of syslog_socket

* Fixed missing leading space

* add missing import

* fixes highvolt-dev#56 breaking change to webapp login after Nokia firmware upgrade to 1.2103.00.0338

* version bump

* add IPv6 ping support, fixes highvolt-dev#43

* use ping6 binary if available for ipv6 ping functionality, fixes highvolt-dev#43

* fix setting IPv6 ping via .env

* conditionally check for lsid cookie to avoid runtime error with nokia 2104 firmware update

* calculate arcaydyan eNB ID using decimal base fixes highvolt-dev#68 caused by firmware update

* safely access 5g band info for arcadyan gateway - fixes highvolt-dev#75

* add support for alternative connectivity checks - fixes highvolt-dev#13 highvolt-dev#78 ; add explicit support for Sagecom gateway

* correct README

* explicitly pass -4 flag to ping command to try ipv4 with ping command except for OS X clients, fixes highvolt-dev#77

---------

Co-authored-by: highvolt-dev <highvoltage@gmail.com>
hugoh added a commit to hugoh/tmo-monitor that referenced this issue May 26, 2023
* Fixed tmo_monitor.gateway module installation

* Update README.md

add Windows directions

* use meaningful exit status codes, fixes highvolt-dev#52

* clarify that a clean run will exit with status code 0 as expected

* add project logo

* First commit to log to syslog - not working yet

Moved all the logging from print_and_log to logging, but syslog doesn't
work. Need to debug.

* Made Linux syslog logging work

* Moved away from f-Strings to lower Python version requirement

* Added support for Windows (untested)

* Fixed log message format

* Fixed out-of-scope use of syslog_socket

* Fixed missing leading space

* add missing import

* fixes highvolt-dev#56 breaking change to webapp login after Nokia firmware upgrade to 1.2103.00.0338

* version bump

* add IPv6 ping support, fixes highvolt-dev#43

* use ping6 binary if available for ipv6 ping functionality, fixes highvolt-dev#43

* fix setting IPv6 ping via .env

* conditionally check for lsid cookie to avoid runtime error with nokia 2104 firmware update

* calculate arcaydyan eNB ID using decimal base fixes highvolt-dev#68 caused by firmware update

* safely access 5g band info for arcadyan gateway - fixes highvolt-dev#75

* add support for alternative connectivity checks - fixes highvolt-dev#13 highvolt-dev#78 ; add explicit support for Sagecom gateway

* correct README

* explicitly pass -4 flag to ping command to try ipv4 with ping command except for OS X clients, fixes highvolt-dev#77

* Pushing on docker-image

---------

Co-authored-by: highvolt-dev <highvoltage@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants