add IPv6 ping support, fixes #43 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoh
reviewed
Feb 6, 2022
| if ping_6: | ||
| if is_osx: | ||
| ping_bin = 'ping6' | ||
| else: |
There was a problem hiding this comment.
@highvolt-dev - this test does not work all the time on Linux. For example, on OpenWrt, there are 2 distinct binaries: ping for IPv4, and ping6 for IPv6. ping -6 is not a valid option:
# opkg list iputils-ping\*
iputils-ping - 20101006-1 - Program ping from iputils.
Sends ICMP ECHO_REQUEST to network hosts (IPv4).
iputils-ping6 - 20101006-1 - Program ping6 from iputils.
Sends ICMP ECHO_REQUEST to network hosts (IPv6).
# ping
Usage: ping [-LRUbdfnqrvVaAD] [-c count] [-i interval] [-w deadline]
[-p pattern] [-s packetsize] [-t ttl] [-I interface]
[-M pmtudisc-hint] [-m mark] [-S sndbuf]
[-T tstamp-options] [-Q tos] [hop1 ...] destination
# opkg files iputils-ping6
Package iputils-ping6 (20101006-1) is installed on root and has the following files:
/usr/bin/ping6
A better test may be to test for a ping6 binary and fall back to ping -6.
hugoh
reviewed
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.