Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset the received memory stream before SerializationException #29

Merged
merged 1 commit into from Dec 13, 2017
Merged

reset the received memory stream before SerializationException #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...munication/Scs/Communication/Protocols/BinarySerialization/BinarySerializationProtocol.cs
View file
Open in desktop
Expand Up @@ -170,6 +170,7 @@ protected virtual IScsMessage DeserializeMessage(byte[] bytes)
}
catch (Exception exception)
{
Reset(); // reset the received memory stream before the exception is rethrown - otherwise the same erroneous message is received again and again
throw new SerializationException("error while deserializing message", exception);
}
}
Expand Down Expand Up @@ -232,6 +233,7 @@ private bool ReadSingleMessage(ICollection<IScsMessage> messages)

//Read bytes of serialized message and deserialize it
var serializedMessageBytes = ReadByteArray(_receiveMemoryStream, messageLength);

messages.Add(DeserializeMessage(serializedMessageBytes));

//Read remaining bytes to an array
Expand Down