Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #186. Add preferMap to decode options #189

Merged
merged 1 commit into from Jan 31, 2024
Merged

Fix #186. Add preferMap to decode options #189

merged 1 commit into from Jan 31, 2024

Conversation

hildjj
Copy link
Owner

@hildjj hildjj commented Jan 30, 2024

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 596afd9 on add-preferMap
into 9733408 on main.

@hildjj hildjj mentioned this pull request Jan 30, 2024
Closed
Wind4Greg
Wind4Greg approved these changes Jan 31, 2024
View reviewed changes
Copy link

@Wind4Greg Wind4Greg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the default behavior be true to conform to the CBOR specs? Thanks for the fix.

@hildjj
Copy link
Owner Author

hildjj commented Jan 31, 2024

Changing the default would be a pretty major breaking change.

@hildjj hildjj merged commit 88781a0 into main Jan 31, 2024
11 checks passed
@hildjj hildjj deleted the add-preferMap branch January 31, 2024 15:51
@hildjj
Copy link
Owner Author

hildjj commented Jan 31, 2024

Fixed in 9.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wind4Greg Wind4Greg Wind4Greg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hildjj @coveralls @Wind4Greg