This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
ES2015 refactor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ES2015/16, semicolons are recommended although not required. To keep the project consistent, this change adds missing semicolons.
This changes the whitespace in main.js to be consistent across the various functions and removes unnecessary whitespace.
ES2015/16 uses `let` and `const` instead of `var`. This change replaces all uses of `var` with the corresponding alternative.
Changed to use a constant for the API url so that it can be used in multiple places easily if needed.
This change alters some ES2015 syntax: - Use backticks for string concatenation containing variables - Move uses of `let` onto one line per definition - Change to use arrow function See: GitHub issue hill#5 See: https://goo.gl/8ZeEdS
Fixed the style of quotes for the Javascript Standard Style for consistency. Also removed trailing commas. See: https://standardjs.com
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a couple of changes regarding ES2015 (ES6) syntaxing.
This follows the Javascript Standard Style.
Feel free to make any edits to this, or request any changes. 馃憤
Closes #5