forked from ngircd/ngircd
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnutls reload cert / Testsuite #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j20d
force-pushed
the
gnutls-reload-cert
branch
from
April 24, 2020 22:04
bd03e57
to
11ea6a5
Compare
hillu
added a commit
that referenced
this pull request
May 10, 2020
This crash was found using American Fuzzy Lop. Minimized input: PASS pwd1 0 0 SERVER ngircd.test.server3 0 SERVER 0 0 0 0 Stacktrace from gdb: #0 __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:65 #1 0x000000000044ac19 in strlcpy (dst=0x7fffffffd120 "@", src=0x0, size=64) at strlcpy.c:59 ngircd#2 0x000000000040f8eb in Client_Search (Nick=0x0) at client.c:605 ngircd#3 0x0000000000440207 in IRC_SERVER (Client=0x47e6b0, Req=0x7fffffffd260) at irc-server.c:189 ngircd#4 0x0000000000448d77 in Handle_Request (Idx=<optimized out>, Req=0x7fffffffd260) at parse.c:544 ngircd#5 Parse_Request (Idx=7, Request=<optimized out>) at parse.c:267 ngircd#6 0x000000000041f668 in Handle_Buffer (Idx=7) at conn.c:1783 ngircd#7 0x00000000004215f9 in Read_Request (Idx=7) at conn.c:1616 ngircd#8 cb_clientserver (sock=7, what=<optimized out>) at conn.c:296 ngircd#9 0x0000000000425ad0 in io_docallback (fd=7, what=<optimized out>) at io.c:924 ngircd#10 io_dispatch_epoll (tv=<optimized out>) at io.c:497 ngircd#11 io_dispatch (tv=<optimized out>) at io.c:896 ngircd#12 0x000000000041eddd in Conn_Handler () at conn.c:748 ngircd#13 0x0000000000405499 in main (argc=<optimized out>, argv=<optimized out>) at ngircd.c:316
hillu
added a commit
that referenced
this pull request
May 10, 2020
I'm not familiar enough with the ngircd codebase, so I am not entirely sure if `Client` is the right variable to pass to `KillClient` or if it should be `c` instead. This crash was found using American Fuzzy Lop. Build flags: ./configure --without-syslog --with-iconv CC=afl-clang Run mode: ngircd -n -f src/testsuite/ngircd-test1.conf Manually inimized input: PASS pwd1 0210-IRC+ Cd|t0:CHLMSX P SERVER ngircd.test.server3 :on :ngi 376 ngircd.test.server :ngircd.test.server3 NICK NickNa.e 1 ~ locst 1 + :e :ngircd.test.server3 JOIN #Channel :e.eEN :ngircd.test.server3 NICK NickName 1 ~ locst 1 + :e :ngircd.test.server3 NJOIN #Channel :@Nickname,,,ngircd.test.server3!d Stacktrace: #0 Client_ID (Client=0x0) at client.c:707 #1 0x000000000042570c in IRC_KillClient (Client=0x0, From=0x0, Nick=0x7fffffffd00c "ngircd.test.server3!d", Reason=<optimized out>) at irc.c:379 ngircd#2 0x000000000044050a in IRC_NJOIN (Client=0x47d6b0, Req=0x7fffffffd260) at irc-server.c:291 ngircd#3 0x0000000000447eb7 in Handle_Request (Idx=<optimized out>, Req=0x7fffffffd260) at parse.c:544 ngircd#4 Parse_Request (Idx=7, Request=<optimized out>) at parse.c:267 ngircd#5 0x000000000041e788 in Handle_Buffer (Idx=7) at conn.c:1817 ngircd#6 0x00000000004206f9 in Read_Request (Idx=7) at conn.c:1650 ngircd#7 cb_clientserver (sock=7, what=<optimized out>) at conn.c:297 ngircd#8 0x0000000000424bd0 in io_docallback (fd=7, what=<optimized out>) at io.c:924 ngircd#9 io_dispatch_epoll (tv=<optimized out>) at io.c:497 ngircd#10 io_dispatch (tv=<optimized out>) at io.c:896 ngircd#11 0x000000000041defd in Conn_Handler () at conn.c:766 ngircd#12 0x0000000000405489 in main (argc=<optimized out>, argv=<optimized out>) at ngircd.c:317
hillu
added a commit
that referenced
this pull request
May 10, 2020
I'm not familiar enough with the ngircd codebase, so I am not entirely sure if `Client` is the right variable to pass to `KillClient` or if it should be `c` instead. This crash (segfault) was found using American Fuzzy Lop. Build flags: ./configure --without-syslog --with-iconv CC=afl-clang Run mode: ngircd -n -f src/testsuite/ngircd-test1.conf Manually inimized input: PASS pwd1 0210-IRC+ Cd|t0:CHLMSX P SERVER ngircd.test.server3 :on :ngi 376 ngircd.test.server :ngircd.test.server3 NICK NickNa.e 1 ~ locst 1 + :e :ngircd.test.server3 JOIN #Channel :e.eEN :ngircd.test.server3 NICK NickName 1 ~ locst 1 + :e :ngircd.test.server3 NJOIN #Channel :@Nickname,,,ngircd.test.server3!d Stacktrace: #0 Client_ID (Client=0x0) at client.c:707 #1 0x000000000042570c in IRC_KillClient (Client=0x0, From=0x0, Nick=0x7fffffffd00c "ngircd.test.server3!d", Reason=<optimized out>) at irc.c:379 ngircd#2 0x000000000044050a in IRC_NJOIN (Client=0x47d6b0, Req=0x7fffffffd260) at irc-server.c:291 ngircd#3 0x0000000000447eb7 in Handle_Request (Idx=<optimized out>, Req=0x7fffffffd260) at parse.c:544 ngircd#4 Parse_Request (Idx=7, Request=<optimized out>) at parse.c:267 ngircd#5 0x000000000041e788 in Handle_Buffer (Idx=7) at conn.c:1817 ngircd#6 0x00000000004206f9 in Read_Request (Idx=7) at conn.c:1650 ngircd#7 cb_clientserver (sock=7, what=<optimized out>) at conn.c:297 ngircd#8 0x0000000000424bd0 in io_docallback (fd=7, what=<optimized out>) at io.c:924 ngircd#9 io_dispatch_epoll (tv=<optimized out>) at io.c:497 ngircd#10 io_dispatch (tv=<optimized out>) at io.c:896 ngircd#11 0x000000000041defd in Conn_Handler () at conn.c:766 ngircd#12 0x0000000000405489 in main (argc=<optimized out>, argv=<optimized out>) at ngircd.c:317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for ssl to testsuite