Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the irregularly sized icons #682

Closed
wants to merge 0 commits into from

Conversation

harshitsahush
Copy link
Contributor

No description provided.

@harshitsahush harshitsahush mentioned this pull request Jan 13, 2023
@harshitsahush
Copy link
Contributor Author

Since github isn't really showing the difference in the .css file, here's what i've done.
Screenshot from 2023-01-13 13-23-15

@hilmanski
Copy link
Owner

if we remove the max-height, then I believe some icons will be stretched down (on height)

@harshitsahush
Copy link
Contributor Author

Since the width and height have been fixed, the image should occupy the given size, and the object-fit should ensure that it doesn't flow out or anything.

I did check the icons after applying these changes. Could you please provide a screenshot where the icons have stretched?

@harshitsahush
Copy link
Contributor Author

Did you check out the changes?

@hilmanski
Copy link
Owner

hi @harshitsahush
Yap here is the sample, when just removing both max and min width

Screen Shot 2023-01-22 at 06 05 55

So I can't merge it for now.

@harshitsahush
Copy link
Contributor Author

Ah, I see. Well, I'll try and fix it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants