Fixed the error in previous pull request #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous pull request, as you mentioned some icons were overflowing. This time i've not removed the max-width/max-height, therefore it wont be an issue now. Instead, i've fixed the issue using flex-shrink property.
Open
harshitsahush
changed the title
I noticed that 2 icons, namely django and wikidpad were still not good. Hence, i've fixed them both by providing align-self prop to all elements so they do not stretch in y-axis.
|
Django and wikidpad were givin me issue but have been fixed. |
|
'Its Foss Community' icon remains to be fixed, since the image provided is not full. |
|
Hi @harshitsahush The file is in /assets/sass don't change the content of css file directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous pull request, as you mentioned some icons were overflowing. This time i've not removed the max-width/max-height, therefore it wont be an issue now. Instead, i've fixed the issue using flex-shrink property.
Here's what i have done:
This should do the trick.