Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in goshiteki#post_submit where leaving buffer fails if file not being written #35

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix a bug in goshiteki#post_submit where leaving buffer fails if file not being written #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion autoload/goshiteki.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ function! g:goshiteki#submit_reviews(status) abort
endfunction

function! g:goshiteki#post_submit(status, tempname, pr_id) abort
let l:body = join(readfile(a:tempname), "\n")
let l:body = ''
if filereadable(a:tempname)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

三項演算子でも良い気がする……！

let l:body = filereadable(a:tempname) ? join(readfile(a:tempname), "\n") : ''

let l:body = join(readfile(a:tempname), "\n")
endif
call system([s:script_dir . 'submit-review.sh', a:pr_id, l:body, a:status, "./.REVIEW_COMMENT_STATE"])
echo "Submit review(status: " . "a:status" . ")"
endfunction
Expand Down