Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SearchStatus with Status type #46

Merged
merged 1 commit into from
Jun 18, 2016

Conversation

sid-kap
Copy link
Contributor

@sid-kap sid-kap commented May 19, 2016

According to https://dev.twitter.com/rest/reference/get/search/tweets, the Search API now returns more detailed Tweet objects:

In API v1.1, the response format of the Search API has been improved to return Tweet objects more similar to the objects you’ll find across the REST API and platform. However, perspectival attributes (fields that pertain to the perspective of the authenticating user) are not currently supported on this endpoint.

The website is not very detailed about this, but I tested the search API with this change and all the fields of Status were there, and everything worked fine.

According to https://dev.twitter.com/rest/reference/get/search/tweets,
the Search API now returns more detailed Tweet objects.
@sid-kap
Copy link
Contributor Author

sid-kap commented May 19, 2016

If you would like, I'd be happy to add a test to show that this feature is indeed working.

@sid-kap
Copy link
Contributor Author

sid-kap commented May 20, 2016

It seems like the Travis test failed because stack could not be downloaded, so we might need to re-run the test.

@himura himura merged commit 3732d27 into himura:master Jun 18, 2016
@sid-kap
Copy link
Contributor Author

sid-kap commented Jun 18, 2016

Thanks!

@sid-kap sid-kap deleted the remove-searchstatusc branch June 18, 2016 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants