Play nicely when behind other proxies #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Matt, thanks for the patch, I'll review it asap. Best,
|
samalba
added a commit
that referenced
this pull request
Sep 25, 2012
Play nicely when behind other proxies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My situation is that I'm running Hipache behind Nginx and then Varnish -- I know it's complicated, but Nginx is for SSL offloading, Varnish is (obviously) for caching, and then Hipache is for load-balancing/failover.
I need the remote (source) IP address to hit the app server, and Hipache was previously only sending the address of the last proxy (which was Varnish).
My implementation changes both the X-Forwarded-For header and the X-Real-IP header. I haven't gone to the effort of converting address to IPv6 -- I wasn't sure why that was being done, I can do another version if that's essential.
Also, I couldn't get the test suite running... I kept getting "Error: Cannot find module 'redis'", which doesn't make much sense. Oh well, I'm pretty new to Node.
Cheers,
Matt