Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not connect to unix socket file #19

Closed
herb123456 opened this issue Mar 12, 2018 · 3 comments
Closed

Can not connect to unix socket file #19

herb123456 opened this issue Mar 12, 2018 · 3 comments
Assignees
@estahn
Labels
enhancement New feature or request

Comments

@herb123456
Copy link 

 # ./php-fpm_exporter_0.4.1_linux_amd64 server --web.listen-address localhost:9101 --phpfpm.scrape-uri unix:///var/run/php71-fpm.sock
INFO[0000] Starting server on localhost:9101 with path /metrics

then test using curl output

ERRO[0002] dial unix :: connect: no such file or directory
ERRO[0002] Error scraping PHP-FPM: dial unix :: connect: no such file or directory

just because uri.Hostname() and uri.Port() is empty when address is unix socket file path at phpfpm/phpfpm.go Line160

I will send a pull request for this issue later.
@herb123456 herb123456 mentioned this issue Mar 12, 2018
Closed
@estahn estahn added the enhancement New feature or request label Mar 12, 2018
@estahn estahn self-assigned this Mar 12, 2018
@estahn
Copy link
Contributor

estahn commented Mar 13, 2018

@herb123456 Unix sockets were not a priority for us, so thanks a lot for your pull request.

Looking at the code we probably need to find a way to integrate #21

Thoughts?

@herb123456
Copy link
Author

that's ok. I will send another pull request a few days later.

estahn added a commit that referenced this issue Mar 17, 2018
@estahn
Implement unix socket support and make status path configurable (Thx @…
35cb0a1 
…herb123456 for the initial implementation) #19 #22
@estahn estahn mentioned this issue Mar 17, 2018
Merged
estahn added a commit that referenced this issue Mar 18, 2018
@estahn
Implement unix socket support and make status path configurable (#23)
8a0c89d 
* Implement unix socket support and make status path configurable (Thx @herb123456 for the initial implementation) #19 #22
* Follow linting guidelines
* Follow linting guidelines
* Move `env` to where it's being used
@estahn
Copy link
Contributor

estahn commented Mar 18, 2018

@herb123456 This issue has been fixed with v0.5.0. Thanks again for your pull request.

@estahn estahn closed this as completed Mar 18, 2018
@wsilva wsilva mentioned this issue Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estahn estahn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@estahn @herb123456