WIP: #2811 introduce circular types

[aksonov]

No description provided.

[southerneer]

One way that I debugged this issue in another project was to use VS Code typing plugins to quickly know when types break. In the screencap below you'll see that the type is any initially and when I comment out the late references the types are restored. Definitely not a solution to our problem, but it can help quickly iterate through possible solutions.

Just thought I'd mention it in case you hadn't stumbled onto this technique already.

[aksonov]

I did it without plugin, it is unusable, because we need these fields, right? Could you try add any to types.late as I wrote in slack?

…

On 25 Oct 2018, at 19:31, Eric Kirkham ***@***.***> wrote: One way that I debugged this issue in another project was to use VS Code typing plugins to quickly know when types break. In the screencap below you'll see that the type is any initially and when I comment out the late references the types are restored. Definitely not a solution to our problem, but it can help quickly iterate through possible solutions. Just thought I'd mention it in case you hadn't stumbled onto this technique already. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[southerneer]

Yep, I'll give it a shot

[southerneer]

It worked!

[aksonov]

Great! Please try to fix other issues if any then, thanks

…

On 25 Oct 2018, at 20:04, Eric Kirkham ***@***.***> wrote: It worked! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[southerneer]

I think we're good to go. AppCenter test "failed" because it isn't configured to build on non-master PRs. I'll go ahead and merge this into 2811 and we can review all in one place there.