Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tile I/O #71

Merged
merged 4 commits into from
Jul 16, 2017
Merged

Improve tile I/O #71

merged 4 commits into from
Jul 16, 2017

Conversation

cdeil
Copy link
Contributor

@cdeil cdeil commented Jul 16, 2017

This pull request:

  • Introduces hips.tile.io as the place where the default HiPS URL and filename are computed
  • Exposes the default URL in a (hopefully) slightly simpler and better way on the existing HipsTileMeta and HipsSurveyProperties classes.
  • Change tile I/O to store raw bytes and use that byte buffer in read / write calls, delaying the extraction of the pixels as a Numpy array to a tile.data property access.
  • Activate test that shows that FITS / JPG and PNG tile read / write now works and roundtrips.
  • Misc code / test / docs cleanup

@cdeil cdeil added this to the 0.1 milestone Jul 16, 2017
@cdeil cdeil self-assigned this Jul 16, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 94.221% when pulling 495485c on cdeil:rgb-tile-io into 91f9eea on hipspy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 96.632% when pulling fdfd672 on cdeil:rgb-tile-io into 91f9eea on hipspy:master.

@cdeil cdeil merged commit 2bc971f into hipspy:master Jul 16, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.7%) to 93.97% when pulling 36c178c on cdeil:rgb-tile-io into 91f9eea on hipspy:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants