-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tile and allsky orientation handling #90
Conversation
I am working towards correct HEALPix <-> HiPS tile pixel mapping, so that we can also generate HiPS, not just read and draw it. What I found is that the up-down flip between FITS relative to {PNG/JPEG} is there both for tiles and all-sky images: One can see that I will implement a function that implements HEALPIX ipix to Hips tile (x, y) pixel coordinate mapping next, and that is yet another case where the up / down flip needs to be taken into account. My current thinking is to move the up / down flip from Line 175 in fc5a870
to a central location where it will be applied correctly for all cases where it needs to be applied. Maybe it could be part of HipsTile.data (and the corresponding reverse from_numpy ) that at that point we call numpy.flipup on the data array?Which tile orientation should we make the "standard" one in our package? I.e. should we always convert to the FITS orientation or the JPEG orientation? @adl1995 @tboch - Please comment if you have any thoughts on this. If I don't hear back, I'll just go ahead and implement a solution I like in this PR and we can then still discuss and change if needed in the coming days / weeks. |
@cdeil I would also prefer if we convert to FITS orientation by default. |
I've made the change to flipping JPG and PNG tiles and all-sky images to the FITS convention in |
I was really struggling with the orientation of tiles and the whole image for the all-sky images. I'm merging this now and will continue with HEALPIX |
This PR improves the all-sky image implementation and tests to also work with FITS images.