-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requires ESM module transformation #39
Comments
This is a significant obstacle in what is otherwise an amazing piece of work -- thank you @shairez ! By researching the error elsewhere, we found a commonly used workaround: configure Jest to transform library code (in this case, include RxJS), to make it possible to work with the deep import. For example, to do that with Nx, adjust
However, this is a somewhat problematic workaround, not a good solution, because it is slow. Possible better solutions:
|
Thanks @wSedlacek and @kylecordes ! |
@shairez could I help with this? Would I be able to open a PR to get it fixed? I think its our last roadblock to updating our repo to v13 |
does not work at the moment with jest. See hirezio/observer-spy#39
@shairez Does this get fixed? my test is failing with the same error for the 2.1.0 version Please advise me the correct version to download `
` |
🎉 This issue has been resolved in version 2.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
I think I managed to solve it |
I am on version 2.2.0 (Angular 17.1.0, Jest 29.7.0) - the following test
(still) gives me
The workaround provided by @kylecordes did not work for me - I haven't looked deeper, though, there... |
When trying to import this into a
@nrwl/nx
configured workspace I get the following error:It appears that using this internal
rxjs
import results in an invalid import in some enviorments.observer-spy/src/fake-time.ts
Line 2 in 00ee48a
The text was updated successfully, but these errors were encountered: