Fix miro log (#87)

* fix miro log * miro sdk don't support log level * https://github.com/miroapp/api-clients/blob/main/packages/miro-api/api/apis.ts#L4905-L4926 * `apiKey` allows undefined and null * this assumes a case where is is not returned by oauth authentification
hiroki0525 · Dec 14, 2023 · d3a1cfc · d3a1cfc
1 parent b9a1ca4
commit d3a1cfc
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 5 deletions.
diff --git a/.changeset/cuddly-lobsters-march.md b/.changeset/cuddly-lobsters-march.md
@@ -0,0 +1,6 @@
+---
+"@dandori/libs": patch
+"@dandori/ui": patch
+---
+
+fix miro log
diff --git a/packages/libs/src/checkApiKey.ts b/packages/libs/src/checkApiKey.ts
@@ -1,7 +1,7 @@
 export function checkApiKey(
   keyName: string,
   targetKey?: string,
-  alternativeKey?: string,
+  alternativeKey?: string | undefined | null,
 ): string {
   if (targetKey) {
     return targetKey;

diff --git a/packages/libs/src/logger.ts b/packages/libs/src/logger.ts
@@ -14,7 +14,7 @@ export const setLogger = (newLogger: Logger): void => {
   logger = newLogger;
 };
 
-type LogLevel = "debug" | "info" | "warn" | "error";
+export type LogLevel = typeof process.env.LOG_LEVEL;
 
 export const getLogLevel = (): LogLevel => {
   return process.env.LOG_LEVEL ?? "info";

diff --git a/packages/ui/src/miro.ts b/packages/ui/src/miro.ts
@@ -12,7 +12,7 @@ import {
 export type GenerateDandoriMiroCardsOptions = {
   boardId: Parameters<MiroApi["getBoard"]>[0];
   isAppCard?: boolean;
-  apiKey?: string;
+  apiKey?: Parameters<typeof checkApiKey>[2];
 };
 
 // miro settings
@@ -66,7 +66,12 @@ export async function generateDandoriMiroCards(
   );
   const logger = getLogger();
   const miroApi = new MiroApi(key, undefined, (...thing) => {
-    logger[getLogLevel()](thing);
+    // miro api sdk has no log level setting, so dandori only log debug level.
+    // https://github.com/miroapp/api-clients/blob/main/packages/miro-api/api/apis.ts#L4905-L4926
+    const logLevel = getLogLevel();
+    if (logLevel === "debug") {
+      logger[logLevel](thing);
+    }
   });
   const miroBoard = await miroApi.getBoard(options.boardId);
   const taskFlat: (DandoriTask & { [taskParentPropName]?: string })[] = tasks

diff --git a/packages/ui/src/notion.ts b/packages/ui/src/notion.ts
@@ -61,7 +61,7 @@ export type DatabasePropertiesMap =
 export type GenerateDandoriNotionPagesOptions = {
   databaseId: string;
   databasePropertiesMap?: DatabasePropertiesMap;
-  apiKey?: string;
+  apiKey?: Parameters<typeof checkApiKey>[2];
 };
 
 const hasStatusProperty = (