Add a basicauth-checking middleware #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to ensure our tests travel the whole Django stack.
This makes it easy to reuse it in other contexts.
Just as apache would do. This allows the middleware to be used in front of Django's ``django.contrib.auth.middleware.RemoteUserMiddleware``.
|
Awesome job! |
|
I checked codes. Great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would add a BasicAuthMiddleware doing a similar job to the current decorator, as suggested in #2 .
In the process of writing this PR, I have felt it useful to alter the code layout to share code between decorators and middleware.
I advise reviewing the PR one commit as a time: each is an atomic unit, and tox tests pass on each commit.