Skip to content

Commit

Permalink
fix: only code-sign on branch main
Browse files Browse the repository at this point in the history
This avoids the issue of PRs from outside contributors failing to sign
due to the secrets not being available.
  • Loading branch information
obycode committed Jan 18, 2022
1 parent 16ccd00 commit 95be4a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ jobs:
npm run build-${{ matrix.platform }}-${{ matrix.architecture }}
- name: Code sign bin (Windows)
if: matrix.os == 'windows-latest'
if: matrix.os == 'windows-latest' && contains(github.ref, 'main')
run: |
$certificate_file_name = "${env:TEMP}\certificate.pfx"
Expand Down

0 comments on commit 95be4a7

Please sign in to comment.