feat: support onCancel #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 456b2bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8 tasks
kyranjamie
reviewed
May 18, 2021
Comment on lines
106
to
108
| if (data.cancel) { | ||
| options.onCancel?.(); | ||
| } else { |
There was a problem hiding this comment.
This implementation works, altering the value of what data and conditionally handling whether the cancel prop is there.
Given we're handling success/fail states, however, maybe we could consider cancel the error state of a the promise?
|
Please add all PRs under review to the Kanban board so we can track them more effectively 🙏
|
fbwoolf
changed the title
fbwoolf
moved this from In Review
to 🕵️♀️ QA
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
fbwoolf
moved this from 🕵️♀️ QA
to In Review
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
fbwoolf
force-pushed
the
feat/cancel-transaction
branch
4 times, most recently
from
704beed
to
48221fd
Compare
fbwoolf
force-pushed
the
feat/cancel-transaction
branch
from
48221fd
to
456b2bc
Compare
👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
automation
moved this from In Review
to 🚀 Done
May 25, 2021
Merged
andresgalante
removed this from 🚀 Done Done
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
onCancelcallback function to a transaction. It also adds a boolean on the tx payload to check if the callback function should be run.Ex.
onCancelwill be called when a user closes/cancels a transaction window.stacks-web-wallet:Issue: leather-wallet/extension#959
PR: leather-wallet/extension#1175
Type of Change
Does this introduce a breaking change?
No.
Are documentation updates required?
No.
Testing information
TBD.
Checklist
yarn lerna run testpasses