Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new modal to allow selecting which wallet to use #341

Merged
merged 20 commits into from Dec 1, 2023

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Nov 15, 2023

This PR was published to npm with the alpha versions:

  • connect npm install @stacks/connect@7.4.3-alpha.edd9f52.0 --save-exact
  • connect-react npm install @stacks/connect-react@22.2.3-alpha.edd9f52.0 --save-exact
  • connect-ui npm install @stacks/connect-ui@6.1.4-alpha.edd9f52.0 --save-exact

Screenshot 2023-11-15 at 15 26 41

Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: edd9f52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@stacks/connect-ui Minor
@stacks/connect Minor
@stacks/connect-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 2:07pm

@eugeniadigon
Copy link

Here's the revised UI for this modal: https://www.figma.com/file/taNNRIyF5NvW2a2KmL1MB8/Connect-UI?type=design&node-id=0%3A1&mode=design&t=Lm6PwiJjB1L3ndLZ-1

Let me know if you have any comments!

browser-1 browser-2 browser

@janniks
Copy link
Collaborator Author

janniks commented Nov 28, 2023

@eugeniadigon thanks 🙏
Screenshot 2023-11-28 at 14 51 01
Updated ✅ I made some minor changes

@janniks janniks force-pushed the fix/solve-multiple-provider-conflict branch from 976c65a to 62f3795 Compare November 28, 2023 14:28
@beguene
Copy link
Member

beguene commented Nov 29, 2023

@janniks I added this to the hiro platform to test.
The popup display the available wallets correctly

Screenshot 2023-11-29 at 15 31 23 Screenshot 2023-11-29 at 15 33 18

But when I installed Xverse and reloaded my page, then clicked on 'Connect', then in the popup I select Xverse, the Leather Wallet pops up instead

Screen.Recording.2023-11-29.at.15.34.39.mov

@eugeniadigon
Copy link

nit: Can you please remove the "www." from the Xverse URL?

Screenshot 2023-11-29 at 15 42 46

packages/connect/src/ui.ts Outdated Show resolved Hide resolved
@janniks
Copy link
Collaborator Author

janniks commented Nov 29, 2023

But when I installed Xverse and reloaded my page, then clicked on 'Connect', then in the popup I select Xverse, the Leather Wallet pops up instead

Thanks @beguene I forgot to add an important handling of providers 🫡 Should be fixed now

@beguene
Copy link
Member

beguene commented Nov 30, 2023

@janniks I installed the latest version

    "@stacks/connect": "7.4.3-alpha.92feb0f.0",
    "@stacks/connect-react": "22.2.3-alpha.92feb0f.0",

But when I click on the 'Connect' button, I get this
image
I also tried with browser cache disabled.

@janniks
Copy link
Collaborator Author

janniks commented Nov 30, 2023

Try adding npm install @stacks/connect-ui@6.1.4-alpha.92feb0f.0 --save-exact -- alpha versions are often not used exactly for dependencies, because npm doesn't know how to follow the semver for commit SHAs.

I just tried on the starters repo and it seems to work 👍


Thanks for testing 🙏 Helps a lot 🚀

Copy link
Member

@beguene beguene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @janniks, --save-exact did the trick.

Code looks good and everything works as intended.

:shipit:

@janniks
Copy link
Collaborator Author

janniks commented Dec 1, 2023

Wonderful thanks for the review 🙇

@janniks janniks merged commit 5284ddf into main Dec 1, 2023
7 checks passed
@janniks janniks deleted the fix/solve-multiple-provider-conflict branch December 1, 2023 15:06
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants