New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add new modal to allow selecting which wallet to use #341
Conversation
janniks
commented
Nov 15, 2023
•
edited by github-actions
bot
edited by github-actions
bot
- A potential solution for Resolve StacksProvider conflict across wallets #325
- Allows for selecting available providers, eliminating conflicts
🦋 Changeset detectedLatest commit: edd9f52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
211dfdb
to
9c9ab8b
Compare
Here's the revised UI for this modal: https://www.figma.com/file/taNNRIyF5NvW2a2KmL1MB8/Connect-UI?type=design&node-id=0%3A1&mode=design&t=Lm6PwiJjB1L3ndLZ-1 Let me know if you have any comments! |
@eugeniadigon thanks 🙏 |
976c65a
to
62f3795
Compare
@janniks I added this to the hiro platform to test. But when I installed Xverse and reloaded my page, then clicked on 'Connect', then in the popup I select Xverse, the Leather Wallet pops up instead Screen.Recording.2023-11-29.at.15.34.39.mov |
Thanks @beguene I forgot to add an important handling of providers 🫡 Should be fixed now |
@janniks I installed the latest version
But when I click on the 'Connect' button, I get this |
Try adding I just tried on the starters repo and it seems to work 👍 Thanks for testing 🙏 Helps a lot 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @janniks, --save-exact
did the trick.
Code looks good and everything works as intended.
Wonderful thanks for the review 🙇 |