Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ordhook docs #514

Merged
merged 8 commits into from
Oct 4, 2023
Merged

add ordhook docs #514

merged 8 commits into from
Oct 4, 2023

Conversation

ryanwaits
Copy link
Contributor

Adding Ordhook documentation to sidebar

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-systems-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 10:04pm

Copy link
Contributor

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few subtle change-edits and nits.

More importantly, you are pulling the remote files correctly, but there are also some local changes to the pulled files, which can be double-checked to be sure.

title: Getting Started
---

Ordhook is a utility designed for interacting with the [Ordinal Theory](https://trustmachines.co/glossary/ordinal-theory) protocol, enabling you to assign distinct identifiers to newly minted satoshis for diverse applications. Follow the steps below to install Ordhook.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utility: tool? command line tool? developer tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates here: hirosystems/ordhook#184

Use the Rust package manager, Cargo, to install Ordhook. Run the following command:

```bash
cargo ordhook-install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command requires to have cargo installed. Considering how detailed our approach is in this guide (cd, git clone, etc) I think we should provide a guide (or provide a pointer) on how to install rust.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates here: hirosystems/ordhook#184

Copy link
Contributor

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanwaits: Your assembly of remote docs from https://github.com/hirosystems/ordhook/tree/develop/docs and the related config changes looks good; however, I am confused as to why you would want the overview.md and getting-started.md files locally also.

They are at the upstream repo, anyway: https://github.com/hirosystems/ordhook/tree/develop/docs

I think simply pointing to those files where the remote plugin dumped in the sidebar.js is all you would need.

I could be misinterpreting, and I am on standby to be corrected.

@ryanwaits
Copy link
Contributor Author

yeah that's nbd, i deleted them locally and will have them ignored by git moving forward

otherwise i think these updates should be in a good spot to go ahead and publish, lmk if we're good to approve!

Copy link
Contributor

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah! Looks good now. Thanks, @ryanwaits!

@ryanwaits ryanwaits merged commit badccc9 into main Oct 4, 2023
2 checks passed
@ryanwaits ryanwaits deleted the ordhook-docs branch October 4, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants