Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update todos.md #84

Closed

Conversation

LakshmiLavanyaKasturi
Copy link
Contributor

  • Small wording changes
  • Grammar
  • Usage of sentences

Description

Describe the changes that were made in this pull request. When possible start with the motivations behind the change. Be sure to also include the following information:

  1. Motivation for change?
  2. What was changed?
  3. Link to relevant issues?

Checklist

  • Conventional commits were used
  • New links to files and images were verified
  • For fixes/refactors: all existing references were identified and replaced
  • Style guide was reviewed and applied
  • Clear code samples were provided
  • People were tagged for review

@vercel
Copy link

vercel bot commented Apr 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/hiro-systems-docs/6Ef1e34QhnnBHsgnmAUFiqFxZeNR
✅ Preview: https://hiro-systems-docs-git-fork-lakshmilavanyakast-dd1bdb-blockstack.vercel.app

@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for hiro-docs ready!

Name Link
🔨 Latest commit 492c939
🔍 Latest deploy log https://app.netlify.com/sites/hiro-docs/deploys/625fadc0e24d5f00086cff1e
😎 Deploy Preview https://deploy-preview-84--hiro-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Apr 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hiro-systems-docs ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 6:53AM (UTC)

@LakshmiLavanyaKasturi
Copy link
Contributor Author

@sabbyanandan: Please review my changes. Thanks.

Copy link
Contributor

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @LakshmiLavanyaKasturi. The todo application is dated when it comes to wallet interaction; the UX/screens have evolved. It'd be great to capture those and update the images.

@LakshmiLavanyaKasturi
Copy link
Contributor Author

Sounds like a future work item. Noted. Thanks!

@LakshmiLavanyaKasturi
Copy link
Contributor Author

Related to #114

Opened an icebox issue to update the todos.md document based on the latest updates. Hence closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants