Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseFloat makes quantities / referenced amounts confusing to end users and integrators #604

Closed
wbnns opened this issue Dec 17, 2021 · 7 comments · Fixed by #612
Closed

parseFloat makes quantities / referenced amounts confusing to end users and integrators #604

wbnns opened this issue Dec 17, 2021 · 7 comments · Fixed by #612
Assignees
@fbwoolf

Comments

@wbnns
Copy link

wbnns commented Dec 17, 2021 •
edited

Describe the bug
The use of parseFloat in the explorer is confusing to integrators and end users because it gives an incorrect perception of the amount being transferred, and the balance of holdings.

Reference # 1, e.g. balance of USDA is not $330,891,881.00:

image

Link to explorer:
https://explorer.stacks.co/address/SPWVN0HJ5RJJWXPAP5JFNZ9Q0V68TVSS1WSG45X6?chain=mainnet

Reference # 2, e.g. this is not a transfer of $11B USD

image

Link to explorer:
https://explorer.stacks.co/txid/0x8e8773bf0693a9ba7543eb2bef58634e91d8fc49cc0c2a5132c391843cf7acc6?chain=mainnet

Expected behavior
Explorer should take decimals into account for token (get-decimals).
@philiphacks
Copy link

+1 - seen this confusion often with Arkadiko users (for all FTs, including USDA and DIKO)

@wbnns
Copy link
Author

wbnns commented Dec 17, 2021

Related: #402

@wbnns wbnns mentioned this issue Dec 18, 2021
Closed
@fbwoolf
Copy link
Contributor

fbwoolf commented Dec 28, 2021

Related: #506

@fbwoolf fbwoolf self-assigned this Dec 28, 2021
@wbnns
Copy link
Author

wbnns commented Dec 28, 2021

@fbwoolf Thanks!

@fbwoolf fbwoolf mentioned this issue Dec 31, 2021
Merged
@fbwoolf fbwoolf linked a pull request Dec 31, 2021 that will close this issue
feat: add sip 10 decimal support #612
Merged
@wbnns
Copy link
Author

wbnns commented Jan 10, 2022

@fbwoolf 🙌

@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 10, 2022

Hoping to release this to production today! 🙌

@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 11, 2022

@wbnns this should be live now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbwoolf fbwoolf

Labels
None yet
Projects
Hiro Wallet (DEPRECATED)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add sip 10 decimal support hirosystems/explorer
3 participants
@philiphacks @wbnns @fbwoolf