fix: inconsistent block transaction results in Rosetta response (#1958)

hirosystems · Apr 23, 2024 · a5bec61 · a5bec61
1 parent 4bba526
commit a5bec61
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/api/controllers/db-controller.ts b/src/api/controllers/db-controller.ts
@@ -467,15 +467,14 @@ export async function getRosettaBlockFromDataStore(
   blockHeight?: number
 ): Promise<FoundOrNot<RosettaBlock>> {
   return await db.sqlTransaction(async sql => {
-    let query;
+    let blockQuery: FoundOrNot<DbBlock>;
     if (blockHash) {
-      query = db.getBlock({ hash: blockHash });
+      blockQuery = await db.getBlock({ hash: blockHash });
     } else if (blockHeight && blockHeight > 0) {
-      query = db.getBlock({ height: blockHeight });
+      blockQuery = await db.getBlock({ height: blockHeight });
     } else {
-      query = db.getCurrentBlock();
+      blockQuery = await db.getCurrentBlock();
     }
-    const blockQuery = await query;
 
     if (!blockQuery.found) {
       return { found: false };