Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zonefiles do not track canonical chain state correctly #1273

Closed
rafaelcr opened this issue Aug 16, 2022 · 0 comments
Closed

zonefiles do not track canonical chain state correctly #1273

rafaelcr opened this issue Aug 16, 2022 · 0 comments
Assignees
Labels
BNS bug Something isn't working

Comments

@rafaelcr
Copy link
Collaborator

The zonefiles table has been returning incorrect results for BNS endpoint queries given that it does not keep the canonical state of the related transaction correctly.

There are lots of instances when an /attachments/new message from the node comes which includes two (or more) updates for the same zonefile but only one of them is actually canonical and valid. As it stands today, the zonefiles table is just UPDATEd with the last received value rather than the correct value.

Another related issue is that no validation is being done to prevent inserting a zonefile with the same hash more than once in the table, making it huge and very difficult to navigate around in event replays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BNS bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant