-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid selecting raw_tx
column on read queries
#1453
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 77.40% 77.91% +0.51%
==========================================
Files 104 104
Lines 10161 10403 +242
Branches 2192 2238 +46
==========================================
+ Hits 7865 8106 +241
- Misses 2187 2189 +2
+ Partials 109 108 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But are we intending for this to go into master
? Doesn't seem like an urgent hotfix release is warranted for this?
@zone117x I think I'll better switch to the |
🎉 This PR is included in version 6.2.2-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [7.0.0-beta.4](v7.0.0-beta.3...v7.0.0-beta.4) (2023-02-03) ### Features * add `smartContractUpdate` and `smartContractLogUpdate` to `PgWriteStore` event emitter ([#1462](#1462)) ([bce0ef9](bce0ef9)) ### Bug Fixes * add block_height index to contract_logs ([#1534](#1534)) ([dc53af2](dc53af2)) * add contract_identifier index on contract_logs table ([#1523](#1523)) ([1f16513](1f16513)) * avoid selecting `raw_tx` column on read queries ([#1453](#1453)) ([5acfc96](5acfc96)) * build rosetta with node 16 ([654b64f](654b64f)) * datastore tests ([bb96507](bb96507)) * is_unanchored property on /extended/v1/tx/:tx_id ([#1487](#1487)) ([4b85058](4b85058)) * lint docs ci dependencies ([#1458](#1458)) ([19c3a0d](19c3a0d)) * stop resolving revoked BNS names ([#1519](#1519)) ([095c4fc](095c4fc)) * test tx types ([11b9013](11b9013)) * update total STX supply to the year 2050 projected amount ([#1531](#1531)) ([0689f60](0689f60))
🎉 This PR is included in version 7.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR removes the
raw_tx
field from all read queries in the API but keeps it for write queries so that this data is still written to the DB.It is not a breaking change since the API never returns the
raw_tx
column in any endpoint except for/extended/v1/tx/{tx_id}/raw
which will stay the same.