Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid selecting raw_tx column on read queries #1453

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Conversation

rafaelcr
Copy link
Collaborator

This PR removes the raw_tx field from all read queries in the API but keeps it for write queries so that this data is still written to the DB.

It is not a breaking change since the API never returns the raw_tx column in any endpoint except for /extended/v1/tx/{tx_id}/raw which will stay the same.

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request November 23, 2022 17:32 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #1453 (dcb9373) into master (93d572e) will increase coverage by 0.51%.
The diff coverage is 89.06%.

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
+ Coverage   77.40%   77.91%   +0.51%     
==========================================
  Files         104      104              
  Lines       10161    10403     +242     
  Branches     2192     2238      +46     
==========================================
+ Hits         7865     8106     +241     
- Misses       2187     2189       +2     
+ Partials      109      108       -1     
Impacted Files Coverage Δ
src/datastore/common.ts 100.00% <ø> (ø)
src/shutdown-handler.ts 0.00% <0.00%> (ø)
src/api/routes/rosetta/construction.ts 73.69% <50.00%> (-0.18%) ⬇️
src/api/routes/rosetta/mempool.ts 81.63% <75.00%> (-0.19%) ⬇️
src/datastore/helpers.ts 74.80% <75.00%> (-0.40%) ⬇️
src/helpers.ts 68.33% <80.00%> (+2.57%) ⬆️
src/api/routes/rosetta/account.ts 88.04% <82.25%> (+0.26%) ⬆️
src/api/routes/ws/channels/ws-rpc-channel.ts 84.57% <82.85%> (-1.14%) ⬇️
src/api/routes/rosetta/network.ts 91.22% <84.61%> (+4.68%) ⬆️
src/api/routes/tokens/tokens.ts 87.11% <85.36%> (-0.39%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But are we intending for this to go into master? Doesn't seem like an urgent hotfix release is warranted for this?

@rafaelcr
Copy link
Collaborator Author

@zone117x I think I'll better switch to the beta branch for this so we can follow that route instead

@rafaelcr rafaelcr changed the base branch from master to beta November 29, 2022 16:09
@rafaelcr rafaelcr merged commit 5acfc96 into beta Nov 29, 2022
@rafaelcr rafaelcr deleted the fix/remove-raw-tx branch November 29, 2022 16:12
blockstack-devops pushed a commit that referenced this pull request Nov 29, 2022
## [6.2.2-beta.1](v6.2.1...v6.2.2-beta.1) (2022-11-29)

### Bug Fixes

* avoid selecting `raw_tx` column on read queries ([#1453](#1453)) ([5acfc96](5acfc96))
* lint docs ci dependencies ([#1458](#1458)) ([19c3a0d](19c3a0d))
@blockstack-devops
Copy link

🎉 This PR is included in version 6.2.2-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Dec 6, 2022
## [6.2.2](v6.2.1...v6.2.2) (2022-12-06)

### Bug Fixes

* avoid selecting `raw_tx` column on read queries ([#1453](#1453)) ([5acfc96](5acfc96))
* lint docs ci dependencies ([#1458](#1458)) ([19c3a0d](19c3a0d))
@blockstack-devops
Copy link

🎉 This PR is included in version 6.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Feb 3, 2023
## [7.0.0-beta.4](v7.0.0-beta.3...v7.0.0-beta.4) (2023-02-03)

### Features

* add `smartContractUpdate` and `smartContractLogUpdate` to `PgWriteStore` event emitter ([#1462](#1462)) ([bce0ef9](bce0ef9))

### Bug Fixes

* add block_height index to contract_logs ([#1534](#1534)) ([dc53af2](dc53af2))
* add contract_identifier index on contract_logs table ([#1523](#1523)) ([1f16513](1f16513))
* avoid selecting `raw_tx` column on read queries ([#1453](#1453)) ([5acfc96](5acfc96))
* build rosetta with node 16 ([654b64f](654b64f))
* datastore tests ([bb96507](bb96507))
* is_unanchored property on /extended/v1/tx/:tx_id ([#1487](#1487)) ([4b85058](4b85058))
* lint docs ci dependencies ([#1458](#1458)) ([19c3a0d](19c3a0d))
* stop resolving revoked BNS names ([#1519](#1519)) ([095c4fc](095c4fc))
* test tx types ([11b9013](11b9013))
* update total STX supply to the year 2050 projected amount ([#1531](#1531)) ([0689f60](0689f60))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants