Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print log and terminate when event-replay fails #944

Closed
CharlieC3 opened this issue Dec 22, 2021 · 0 comments · Fixed by #980
Closed

Print log and terminate when event-replay fails #944

CharlieC3 opened this issue Dec 22, 2021 · 0 comments · Fixed by #980
Assignees
@MHassanTariq
Labels
P2 Priority 2 Critical functionality not working Impacts one/few customers

Comments

@CharlieC3
Copy link
Member

Describe the bug
If event-replay fails, the error gets logged but it doesn't report that the replay failed. This makes it difficult to automatically detect through automated systems.

Expected behavior
In addition to the error, a line should print out noting that the event-replay process failed due to the aforementioned error.
And if it doesn't already, a failed event-replay should return a non-zero status code as well.
@saralab saralab added the P2 Priority 2 Critical functionality not working Impacts one/few customers label Jan 11, 2022
@MHassanTariq MHassanTariq mentioned this issue Jan 17, 2022
Merged
9 tasks
@MHassanTariq MHassanTariq linked a pull request Jan 17, 2022 that will close this issue
Print additional log for failing event-replay #980
Merged
9 tasks
@MHassanTariq MHassanTariq self-assigned this Jan 17, 2022
zone117x pushed a commit that referenced this issue Jan 21, 2022
@MHassanTariq
chore: print additional log for failing event-replay #944 (#980)
d410143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MHassanTariq MHassanTariq

Labels
P2 Priority 2 Critical functionality not working Impacts one/few customers
Projects
API Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print additional log for failing event-replay hirosystems/stacks-blockchain-api
4 participants
@rafaelcr @saralab @CharlieC3 @MHassanTariq