fix: ensure Cache-Control is specified in 304 response
#971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by some CDNs to cache properly
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 66.88% 66.90% +0.01%
==========================================
Files 95 95
Lines 10036 10040 +4
Branches 1573 1623 +50
==========================================
+ Hits 6713 6717 +4
Misses 3319 3319
Partials 4 4
Continue to review full report at Codecov.
|
blockstack-devops
pushed a commit
that referenced
this pull request
Jan 12, 2022
## [1.0.7](v1.0.6...v1.0.7) (2022-01-12) ### Bug Fixes * ensure `Cache-Control` is specified in 304 response as required by some CDNs to cache properly ([#971](#971)) ([a0fd2fe](a0fd2fe))
|
🎉 This PR is included in version 1.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes caching issue with certain CDNs (e.g. Cloudflare) where intermediate caching will only be performed if the
304 CACHE OKresponse also includes theCache-Controlheaders.Cloudflare will perform intermediate caching when the following page rules are applied for
/v1/extended/*: