Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not mine until previous block is confirmed #320

Closed
wants to merge 1 commit into from

Conversation

obycode
Copy link
Member

@obycode obycode commented Jul 11, 2023

The subnet miner should not mine a new anchor block until the previous block commit has been confirmed.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #320 (0d4e33d) into develop (aa75e92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #320   +/-   ##
========================================
  Coverage    60.00%   60.00%           
========================================
  Files            4        4           
  Lines           45       45           
  Branches         6        6           
========================================
  Hits            27       27           
  Misses          18       18           

@obycode obycode marked this pull request as ready for review July 11, 2023 22:54
@obycode obycode requested a review from jbencin July 11, 2023 23:01
The subnet miner should not mine a new anchor block until the previous
block commit has been confirmed.
@obycode
Copy link
Member Author

obycode commented Jul 12, 2023

Closing because this would not handle new deposits in the reforged branch correctly.

@obycode obycode closed this Jul 12, 2023
@obycode obycode deleted the feat/wait-to-mine branch July 12, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant