Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update block handling for new model #323

Merged
merged 1 commit into from Jul 17, 2023
Merged

Conversation

obycode
Copy link
Member

@obycode obycode commented Jul 13, 2023

The latest mining model will only submit one block commit per burn block and it will be successful if it lands in a later block than the one it was intended for.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #323 (d06e152) into develop (2c217a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #323   +/-   ##
========================================
  Coverage    60.00%   60.00%           
========================================
  Files            4        4           
  Lines           45       45           
  Branches         6        6           
========================================
  Hits            27       27           
  Misses          18       18           

@obycode obycode marked this pull request as ready for review July 13, 2023 21:24
@obycode obycode requested review from kantai and jbencin July 13, 2023 21:24
The latest mining model will only submit one block commit per burn block
and it will be successful if it lands in a later block than the one it
was intended for.
Copy link
Contributor

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obycode obycode merged commit fee2fe5 into develop Jul 17, 2023
32 checks passed
@obycode obycode deleted the fix/handle-missed-block branch July 17, 2023 17:24
@blockstack-devops
Copy link
Contributor

🎉 This PR is included in version 0.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants