fix: throw error if authType not set

hirosystems · Sep 2, 2021 · 8ae3f34 · 8ae3f34
1 parent 89ffc74
commit 8ae3f34
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/transactions/src/signer.ts b/packages/transactions/src/signer.ts
@@ -2,7 +2,7 @@ import { StacksTransaction } from './transaction';
 
 import { StacksPrivateKey, StacksPublicKey } from './keys';
 import { isSingleSig, nextVerification, SpendingConditionOpts } from './authorization';
-import { cloneDeep } from './utils';
+import { cloneDeep, txidFromData } from './utils';
 import { AuthType, PubKeyEncoding, StacksMessageType } from './constants';
 import { SigningError } from './errors';
 
@@ -26,10 +26,14 @@ export class TransactionSigner {
     if (spendingCondition && !isSingleSig(spendingCondition)) {
       spendingCondition.fields.forEach(field => {
         if (field.contents.type === StacksMessageType.MessageSignature) {
+          if (!transaction.auth.authType) {
+            throw Error('"transaction.auth.authType" not defined');
+          }
+
           const signature = field.contents;
           const nextVerify = nextVerification(
             this.sigHash,
-            transaction.auth.authType!,
+            transaction.auth.authType,
             spendingCondition!.fee,
             spendingCondition!.nonce,
             PubKeyEncoding.Compressed, // always compressed for multisig