fix: convert checksum to buffer

hirosystems · Jul 11, 2022 · 963b028 · 963b028 · vercel · Jul 11, 2022
1 parent bc6c1a2
commit 963b028
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/encryption/src/keys.ts b/packages/encryption/src/keys.ts
@@ -62,7 +62,7 @@ export function base58CheckDecode(btcAddress: string): {
  * @ignore
  */
 export function base58Encode(hash: Buffer) {
-  const checksum = sha256(sha256(hash));
+  const checksum = Buffer.from(sha256(sha256(hash)));
   return base58.encode(Buffer.concat([hash, checksum], hash.length + 4));
 }
 

diff --git a/packages/encryption/tests/keys.test.ts b/packages/encryption/tests/keys.test.ts
@@ -4,13 +4,13 @@ import { address, ECPair, networks } from 'bitcoinjs-lib';
 import bs58check from 'bs58check';
 import { SECP256K1Client } from 'jsontokens';
 import {
+  base58Encode,
+  compressPrivateKey,
+  ecSign,
   getPublicKeyFromPrivate,
   hashSha256Sync,
   makeECPrivateKey,
   publicKeyToAddress,
-  ecSign,
-  base58Encode,
-  compressPrivateKey,
 } from '../src';
 import { hashRipemd160 } from '../src/hashRipemd160';